Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore initial server response. #191

Merged
merged 3 commits into from
Jul 6, 2022
Merged

fix: ignore initial server response. #191

merged 3 commits into from
Jul 6, 2022

Conversation

sitaram-kalluri
Copy link
Member

@sitaram-kalluri sitaram-kalluri commented Jul 4, 2022 •
edited

- What I did

  1. When new connection is established, ignore the initial server response - @
  2. Edit the pubspec.yaml of onboarding functional test to pick the at_lookup from the path. So that the current branch at_lookup package is picked up.

- How I did it

  1. Added an IF condition that ignores, the @ prompt.

- How to verify it

- Description for the changelog

gkc
gkc approved these changes Jul 5, 2022
View reviewed changes
at_onboarding_cli/functional_tests/pubspec.yaml
url: https://github.com/atsign-foundation/at_libraries.git
path: at_lookup
ref: trunk
path: ../../at_lookup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove this dependency override after this pull request has been merged to trunk

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkc: Just a thought, Can we leave dependency overrides with path so that for subsequent pushes, at_lookup will be picked from the current branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that function tests will run the current branch instead of trunk branch. We can catch the issue when we raise PR, instead of knowing them after we merge to trunk branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry, yes of course that makes sense since it's all in the same repo and we're talking about the functional tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkc: Thank you. So leaving the dependency_overrides as is pointing to path.

@sitaram-kalluri sitaram-kalluri merged commit f71f6d8 into trunk Jul 6, 2022
@sitaram-kalluri sitaram-kalluri deleted the enhance_buffer branch July 8, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkc gkc gkc approved these changes

@murali-shris murali-shris Awaiting requested review from murali-shris

@VJag VJag Awaiting requested review from VJag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sitaram-kalluri @gkc