fix: skip commit id and sync for signing keys #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkc
previously requested changes
Sep 5, 2022
| key.startsWith(RegExp('private:|privatekey:|public:_'))) { | ||
| (key.startsWith(RegExp( | ||
| 'private:|privatekey:|public:_|public:signing_publickey')) || | ||
| key.contains(AT_SIGNING_PRIVATE_KEY))) { |
There was a problem hiding this comment.
Use of contains seems potentially buggy. Why not an exact match?
There was a problem hiding this comment.
format of the key is <current_atsign>:signing_privatekey<current_atsign>
There was a problem hiding this comment.
key.startsWith(RegExp('@(?<sharedWith>.*):signing_privatekey@(?<sharedBy>.*)'))
is this fine?
VJag
reviewed
Sep 6, 2022
| @@ -341,8 +341,7 @@ class CommitLogKeyStore | |||
| if ((RegExp(regex).hasMatch(atKey)) || | |||
| atKey.contains(AT_ENCRYPTION_SHARED_KEY) || | |||
There was a problem hiding this comment.
Should we refactor this to:
match = _isRegexMatches() || _isSpecialKey();
_isSpecialKey contains checking for special keys
There was a problem hiding this comment.
yeah..sounds good.i will make the changes
…ion/at_server into sync_skipkeys_bug
VJag
approved these changes
Sep 12, 2022
murali-shris
dismissed
gkc’s stale review
@gkc addressed the comments. dismissing the review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it