Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better conversion of AtExceptions to @ protocol error codes #152

Open
gkc opened this issue Feb 11, 2022 · 3 comments
Open

Better conversion of AtExceptions to @ protocol error codes #152

gkc opened this issue Feb 11, 2022 · 3 comments
Assignees
@gkc @sitaram-kalluri
Labels
bug Something isn't working

Comments

@gkc
Copy link
Contributor

gkc commented Feb 11, 2022 •
edited
Loading

Describe the bug

  • Some valid AtExceptions are not mentioned in the error_codes conversion map in at_commons/lib/src/exception/error_message.dart
  • When one of those AtExceptions is thrown, it results in error responses to clients like this error:null-null : ...

Expected behaviour

  • All AtExceptions need to be included in the error_codes conversion map
  • Consider also extending at_commons error_message.dart with a way to create (not throw, just create) the correct exception given an error code. (We currently have mapping from exception to error-code but not the other way around). This makes it easier for servers to intelligently 'forward' exceptions (for example as described in Error code 'forwarding' at_server#509)
@gkc gkc added the bug Something isn't working label Feb 11, 2022
@gkc gkc self-assigned this Feb 11, 2022
@gkc gkc mentioned this issue Feb 11, 2022
Closed
@gkc
Copy link
Contributor Author

gkc commented Feb 11, 2022

@kalluriramkumar As per our discussion. If you want to pick this one up, please assign yourself and go ahead!

@gkc
Copy link
Contributor Author

gkc commented Jul 25, 2022

@kalluriramkumar Is this obsolete now?

@XavierChanth
Copy link
Member

@gkc @sitaram-kalluri can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gkc gkc

@sitaram-kalluri sitaram-kalluri

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gkc @sitaram-kalluri @XavierChanth