Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate required data types in at_onboarding_flutter #583

Closed
ralfeus opened this issue Dec 19, 2022 · 3 comments
Closed

Encapsulate required data types in at_onboarding_flutter #583

ralfeus opened this issue Dec 19, 2022 · 3 comments
Assignees
Labels
2 SP More than an hour less than a day bug Something isn't working PR53 Jan 2023 Sprint Planning

Comments

@ralfeus
Copy link

ralfeus commented Dec 19, 2022

Which at_widget package you find issue with?

at_onboarding_flutter

On what platforms did you experience the issue?

Android, iOS, Windows, MacOS, Linux

What version are you using?

at_onboarding_flutter: 5.0.5

What happened?

AtOnboarding.onboard() requires a config parameter of type AtOnboardingConfig, which is a part of at_onboarding_flutter package. Its constructor requires in its turn atClientPreference parameter of type AtClientPreference. This type is not a part of at_onboarding_flutter nor exposed by one. So it's hard to figure what else should be added to dependencies to make the project running.
I recommend to expose AtClientPreference by at_onboarding_flutter package

Steps to reproduce

1. Create widget from example:

  Widget build(BuildContext context) {
      final atClientPreference = AtClientPreference();
      return TextButton(
      onPressed: () async {
        final result = await AtOnboarding.onboard(
          context: context,
          config: AtOnboardingConfig(
            atClientPreference: atClientPreference,
            domain: 'atkrypto.io',
            rootEnvironment: RootEnvironment.Testing,
            appAPIKey: AtEnv.appApiKey,
          ),
        );
    }

2. Observe impossibility to compile
...

Additional info

No response

Relevant log output

No response

Flutter analyze output

No response

Flutter doctor output

No response

@ralfeus ralfeus added the bug Something isn't working label Dec 19, 2022
@ksanty
Copy link
Member

ksanty commented Jan 9, 2023

Is this a documentation update @sachins-geekyants

@ksanty ksanty added 3 SP 3 Story Points - 1 Day Small 2 SP More than an hour less than a day PR53 Jan 2023 Sprint Planning and removed 3 SP 3 Story Points - 1 Day Small labels Jan 9, 2023
sonle-geekyants added a commit that referenced this issue Jan 11, 2023
@sonle-geekyants
Copy link
Contributor

#594 This is my PR, please check it @sachins-geekyants @ralfeus

@sachins-geekyants
Copy link
Contributor

Fix released in at_onboarding_flutter: ^6.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 SP More than an hour less than a day bug Something isn't working PR53 Jan 2023 Sprint Planning
Projects
None yet
Development

No branches or pull requests

4 participants