Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for GUI sshnp client #367

Merged
merged 20 commits into from
Aug 23, 2023
Merged

feat: Add support for GUI sshnp client #367

merged 20 commits into from
Aug 23, 2023

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Aug 18, 2023

- What I did

Arguments:

  • Fixed a bunch of merge conflicts related to adding multiple args to SSHNP
    • Added trailing commas to parameter lists to reduce the chances of this kind of merge conflict from reoccurring
  • Made legacyDaemon arg optional and provided a default
  • Added static const default* arguments to SSHNP class
  • Made all port args int type instead of String type

SSHRV:

  • Added an abstract class with localBinary and pureDart factory functions
  • localBinary runs in a separate process so that CLIs can exit
  • pureDart is needed so that the GUI is not dependant on separate binaries elsewhere

Misc:

  • Now using part/part of notation for related files
  • Added SSHNPResult class, which overrides toString to output the ssh command for CLI, but the class can be intercepted for the GUI

- How I did it

- How to verify it

- Description for the changelog
feat: Add support for GUI sshnp client

@XavierChanth
Copy link
Member Author

Need to merge #366 to fix the rest of the tests

@XavierChanth XavierChanth marked this pull request as ready for review August 22, 2023 16:17
@XavierChanth XavierChanth changed the title feat: sshnp changes for gui [WIP] feat: Add support for GUI sshnp client Aug 22, 2023
@XavierChanth XavierChanth requested a review from gkc August 22, 2023 16:17
@XavierChanth XavierChanth requested a review from gkc August 23, 2023 06:00
@gkc gkc merged commit d4990e3 into trunk Aug 23, 2023
21 checks passed
@gkc gkc deleted the sshnp-changes-for-gui branch August 23, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants