Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove file system bindings #516

Merged
merged 68 commits into from
Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from 67 commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
be15739
feat: checkin webserver code
XavierChanth Oct 3, 2023
62a51da
feat: add webserver portion
XavierChanth Oct 3, 2023
c3f4826
fix: path to binary dart files
XavierChanth Oct 3, 2023
8f08ed5
fix: mount path
XavierChanth Oct 3, 2023
8770687
chore: cleanup webserver setup
XavierChanth Oct 3, 2023
ae190ee
chore: setup mobile endpoints code
XavierChanth Oct 3, 2023
4bb2409
chore: safely guarantee a homeDirectory in noports_core
XavierChanth Oct 3, 2023
8c2c18a
chore: remove unused import
XavierChanth Oct 3, 2023
173144e
chore: flatten webserver demo
XavierChanth Oct 3, 2023
a23bc41
checkin webserver demo
XavierChanth Oct 4, 2023
59a1c87
chore: prevent double init completion on error
XavierChanth Oct 4, 2023
c5ab1ce
chore: decouple local filesystem from SSHNPImpl family
XavierChanth Oct 4, 2023
b0aa277
docs: add sshnp_class_diagrams.md
XavierChanth Oct 4, 2023
2a05805
Merge branch 'trunk' into remove-file-system-bindings
XavierChanth Oct 4, 2023
f3ce8f1
chore: organize utils and remove dependency on path_provider
XavierChanth Oct 4, 2023
4025f49
fix: remove path_provider dep
XavierChanth Oct 4, 2023
6163de5
chore: use new guarantees
XavierChanth Oct 4, 2023
342f9d5
fix: DefaultArg typings
XavierChanth Oct 4, 2023
f76285a
feat: complete sshKeyPair implementation in sshnp params
XavierChanth Oct 4, 2023
f394e84
fix: avoid late init errors
XavierChanth Oct 4, 2023
9832956
fix: file system binding removal
XavierChanth Oct 5, 2023
fe4dcab
fix: entrypoints for new -i arg
XavierChanth Oct 5, 2023
c5bb379
fix: use -e for arg replacement
XavierChanth Oct 5, 2023
d0224af
fix: escape sed expression
XavierChanth Oct 5, 2023
7d91e3f
fix: use non-path delimiter
XavierChanth Oct 5, 2023
5c2fa2b
fix:
XavierChanth Oct 5, 2023
8dc51a0
fix: try to prevent globbing
XavierChanth Oct 5, 2023
25fe4ec
fix: try no eval
XavierChanth Oct 5, 2023
d747e04
docs: comment a design decision
XavierChanth Oct 5, 2023
50e3d08
chore: debugprint username
XavierChanth Oct 5, 2023
27f7ec2
fix: return userName instead of null
XavierChanth Oct 5, 2023
3937121
fix: args
XavierChanth Oct 5, 2023
b071917
chore: checkin
XavierChanth Oct 5, 2023
0633bff
refactor: new hierarchy
XavierChanth Oct 5, 2023
3c69372
Merge remote-tracking branch 'origin/trunk' into remove-file-system-b…
XavierChanth Oct 5, 2023
0432202
chore: remove webserver example
XavierChanth Oct 5, 2023
d2f307f
refactor: arg parsing
XavierChanth Oct 5, 2023
e7f96c3
chore: remove late from params
XavierChanth Oct 5, 2023
ed4b699
chore: use enum for ssh algorithms
XavierChanth Oct 5, 2023
d80a459
chore: propagate sshalg changes
XavierChanth Oct 5, 2023
4d0d512
chore: use payload handler mixins
XavierChanth Oct 5, 2023
8bae438
feat: add ssh key util
XavierChanth Oct 6, 2023
6aa2498
chore: cast enums to strings
XavierChanth Oct 6, 2023
8ea8f54
chore: defer key handling to SSHKeyUtil
XavierChanth Oct 6, 2023
167d5ef
chore: mark TODO
XavierChanth Oct 6, 2023
dfc2b7d
chore: cleanup
XavierChanth Oct 6, 2023
f303edd
fix: parameter typing
XavierChanth Oct 6, 2023
b950274
chore: make directory internal to AtSSHKeyPair
XavierChanth Oct 6, 2023
bce7b9c
chore: update parser
XavierChanth Oct 6, 2023
374b3ae
chore: checkin code
XavierChanth Oct 6, 2023
1970cec
chore: finish implementing sshnp key management
XavierChanth Oct 6, 2023
e3add56
docs: update comments
XavierChanth Oct 6, 2023
d648ec9
fix: delay use of ephemeralPrivateKey until after initialization
XavierChanth Oct 6, 2023
693984f
chore: log notification value
XavierChanth Oct 6, 2023
e7319d0
chore: log all inits
XavierChanth Oct 6, 2023
76b400f
chore: log when the ephemeral privateKey is set
XavierChanth Oct 6, 2023
1471bc1
fix: build ephemeral affter requesting an ssh connection
XavierChanth Oct 6, 2023
8cbca2a
chore: cleanup logging
XavierChanth Oct 6, 2023
07b5d58
chore: print params during init
XavierChanth Oct 6, 2023
5a8667f
fix: add typesafety to sshnp args in sshnp params
XavierChanth Oct 6, 2023
5c7d6e1
chore: rename cliArg for ssh-client from pure-dart to dart (since ssh…
XavierChanth Oct 6, 2023
f91cdca
chore: add a todo
XavierChanth Oct 6, 2023
589f735
chore: add a todo
XavierChanth Oct 6, 2023
cb83e69
docs: update diagrams
XavierChanth Oct 6, 2023
51d7c0f
chore: remove identityType (not needed)
XavierChanth Oct 6, 2023
985e013
chore: comment
XavierChanth Oct 6, 2023
9be9001
chore: change import file name
XavierChanth Oct 6, 2023
659f604
chore: remove unused dep
XavierChanth Oct 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/composite/setup_entrypoints/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ inputs:
devicename:
description: Unique sshnp devicename
required: true
legacy_daemon:
description: Legacy daemon
args:
description: Arguments to pass to the entrypoint
required: false

runs:
Expand All @@ -33,14 +33,26 @@ runs:
working-directory: tests/end2end_tests/contexts/_init_
run: |
case "${{ inputs.sshnp }}" in
"installer")
installer|v3.*.*)
# legacy client
args="-s id_ed25519.pub -v"
entrypoint_filename="sshnp_installer_entrypoint.sh"
;;
*)
entrypoint_filename="sshnp_entrypoint.sh"
case "${{inputs.sshnpd}}" in
installer|v3.*.*)
# v4 client, legacy daemon
args="-i ~/.ssh/id_ed25519 -s -v --legacy-daemon"
;;
*)
# v4 client, v4 daemon
args="-i ~/.ssh/id_ed25519 -s -v"
;;
esac
;;
esac
./setup-sshnp-entrypoint.sh ${{ inputs.devicename }} ${{ inputs.sshnp_atsign }} ${{ inputs.sshnpd_atsign }} ${{ inputs.sshrvd_atsign }} "$entrypoint_filename" ${{ inputs.legacy_daemon || false }}
./setup-sshnp-entrypoint.sh ${{ inputs.devicename }} ${{ inputs.sshnp_atsign }} ${{ inputs.sshnpd_atsign }} ${{ inputs.sshrvd_atsign }} "$entrypoint_filename" "$args ${{ inputs.args }}"

- name: Setup NPD entrypoint
shell: bash
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/end2end_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ env:
DOCKER_COMPOSE_UP_CMD: "docker compose up --abort-on-container-exit"

RELEASES: |
latest
v3.1.2
v3.2.0
v3.3.0
v3.4.0
v3.4.2

BRANCHES: |
trunk
Expand Down Expand Up @@ -244,7 +244,6 @@ jobs:
sshnpd_atsign: ${{ env.SSHNPD_ATSIGN }}
sshrvd_atsign: ${{ env[env.PROD_RVD_ATSIGN] }}
devicename: ${{ env.DEVICENAME }}
legacy_daemon: ${{ matrix.np == 'local' && matrix.npd == 'installer' }}

- name: Ensure entrypoints exist
working-directory: tests/end2end_tests/contexts
Expand Down Expand Up @@ -370,13 +369,11 @@ jobs:
include:
- np: local
npd: v3.4.2
legacy_daemon: true
- np: v3.4.2
npd: local

- np: local
npd: v3.3.0
legacy_daemon: true
- np: v3.3.0
npd: local

Expand Down Expand Up @@ -418,7 +415,7 @@ jobs:
sshnpd_atsign: ${{ env.SSHNPD_ATSIGN }}
sshrvd_atsign: ${{ env[env.PROD_RVD_ATSIGN] }}
devicename: ${{ env.DEVICENAME }}
legacy_daemon: ${{ matrix.legacy_daemon || false }}
args: "-P 55"

- name: Ensure entrypoints exist
working-directory: tests/end2end_tests/contexts
Expand Down Expand Up @@ -551,7 +548,7 @@ jobs:
- name: Set up entrypoints
working-directory: tests/end2end_tests/contexts/_init_
run: |
./setup-sshnp-entrypoint.sh ${{ env.DEVICENAME }} ${{ env.SSHNP_ATSIGN }} ${{ env.SSHNPD_ATSIGN }} ${{ env[env.PROD_RVD_ATSIGN] }} alternate_port_test/sshnp_entrypoint.sh
./setup-sshnp-entrypoint.sh ${{ env.DEVICENAME }} ${{ env.SSHNP_ATSIGN }} ${{ env.SSHNPD_ATSIGN }} ${{ env[env.PROD_RVD_ATSIGN] }} sshnp_entrypoint.sh "-i ~/.ssh/id_ed25519 -s -v -P 55"
./setup-sshnpd-entrypoint.sh ${{ env.DEVICENAME }} ${{ env.SSHNP_ATSIGN }} ${{ env.SSHNPD_ATSIGN }} sshnpd_entrypoint.sh

- name: Ensure entrypoints exist
Expand Down
1 change: 0 additions & 1 deletion examples/.gitignore

This file was deleted.

Loading
Loading