Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: terminal session and private key issues #688

Merged
merged 3 commits into from Jan 17, 2024

Conversation

CurtlyCritchlow
Copy link
Contributor

- What I did
Fixed terminal session failing to close when ssh fails under certain conditions.
Fixed profile private key local storage not deleting when the complimentary private key is deleted.
Fixed profile name accepting uppercase letters
- How I did it

- How to verify it

  1. Fun the flutter project
  2. ssh with an invalid session user name, the created terminal should automatically close
  3. delete a private key associated with a profile in the settings screen, expect the profile edit screen private key dropdown to have a null initial value ie no private key will be shown.
    - Description for the changelog

Fixed terminal session and private key issues

@XavierChanth XavierChanth merged commit b539fb4 into trunk Jan 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants