chore: added msix config #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierChanth
approved these changes
Jan 19, 2024
gkc
reviewed
Jan 21, 2024
| msix_config: | ||
| display_name: "SSH No Ports Desktop" | ||
| publisher_display_name: "Atsign" | ||
| identity_name: "TheCompany.SSHNoPortsDesktop" |
There was a problem hiding this comment.
Should we change the identity name from "TheCompany.SSHNoPortsDesktop" to "Atsign.SSHNoPortsDesktop" ? Or is it not relevant / important?
There was a problem hiding this comment.
It's for internal use and is not shown on windows stores.
We can keep it as it is.
There was a problem hiding this comment.
It's for internal use and is not shown on windows stores. We can keep it as it is.
I think it would be better to change it unless that will cause a problem
There was a problem hiding this comment.
It can not be changed even if we update organisation name, identity_name will remain same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Description for the changelog