Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(BREAKING CHANGE): add -x flag #705

Merged
merged 6 commits into from Jan 22, 2024
Merged

Conversation

XavierChanth
Copy link
Member

By default sshnp now immediately drops into a prompt for clients that don't support sshnp.canRunShell(). -x allows the ssh command to be output instead of executing ssh immediately.

- What I did

  • Set the default mode for sshnp to execute ssh as a child process
  • Added -x / --output-execution-command flag

- How I did it

- How to verify it

- Description for the changelog
feat(BREAKING CHANGE): add -x flag

By default sshnp now immediately drops into a prompt for clients that don't support sshnp.canRunShell(). -x allows the ssh command to be output instead of executing ssh immediately.
@XavierChanth XavierChanth changed the title feat(BREAKING CHANGE): add -x flag feat(WIP / BREAKING CHANGE): add -x flag Jan 22, 2024
@XavierChanth XavierChanth marked this pull request as draft January 22, 2024 08:51
@XavierChanth XavierChanth marked this pull request as ready for review January 22, 2024 11:26
@XavierChanth XavierChanth changed the title feat(WIP / BREAKING CHANGE): add -x flag feat(BREAKING CHANGE): add -x flag Jan 22, 2024
@gkc gkc merged commit f918307 into socket-authenticator-option Jan 22, 2024
2 checks passed
@gkc gkc deleted the execution-flag branch January 22, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants