Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v5 args tweaking #720

Merged
merged 8 commits into from Jan 24, 2024
Merged

feat: v5 args tweaking #720

merged 8 commits into from Jan 24, 2024

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Jan 24, 2024 •
edited

- What I did

  • feat: Sshnp: default discoverDaemonFeatures to false
  • fix: SshnpArg: when creating ArgParser, add aliases (if any) for flags as well as for (currently) options
  • feat: SshnpArg: Remove abbreviations for the new flags, add suitabe short aliases instead
  • feat: supply usageLineLength to sshnpd's ArgParser
  • feat: use fork of args package, so that usage output includes alias(es)
  • chore: style: dart format
  • refactor: better readability in print_version.dart

- How I did it

  • See commits

- How to verify it

  • Tests pass
  • binaries' usage output should include alias(es) - e.g. for sshnp 
      --[no-]authenticate-client-to-rvd,--[no-]ac 
  --[no-]authenticate-device-to-rvd,--[no-]ad
  --[no-]encrypt-rvd-traffic,--[no-]et
  --[no-]discover-daemon-features,--[no-]ddf

@gkc gkc requested a review from XavierChanth January 24, 2024 12:25
@gkc
chore: style: dart format
cd62a5d 
refactor: better readability in print_version.dart
XavierChanth
XavierChanth reviewed Jan 24, 2024
View reviewed changes
packages/dart/sshnoports/lib/src/print_version.dart

/// Print version number
void printVersion() {
stderr.writeln('Version : ${release.packageVersion} (core: ${package.packageVersion}');
stderr.writeln('Version : ${binaries.packageVersion}'
' (core: ${core.packageVersion}');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the closing bracket for (core: x.x.x)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - will fix in next PR

@gkc gkc merged commit db15e9c into trunk Jan 24, 2024
6 checks passed
@gkc gkc deleted the gkc/sshnp-arg-aliases-and-defaults branch January 24, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierChanth XavierChanth XavierChanth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gkc @XavierChanth