New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
758 provide more useful messages in the UI when a session is being created #764
758 provide more useful messages in the UI when a session is being created #764
Conversation
While it makes sense to say "when false, <negative effects>" for the CLI because they are on by default. In the UI we should always use the positive: "when turned on, <positive effects>" since we have a visual indication showing that these are on. |
@@ -31,12 +31,12 @@ dependencies: | |||
intl: any | |||
macos_ui: ^2.0.0 | |||
mocktail: ^1.0.0 | |||
noports_core: ^5.0.0 | |||
noports_core: ^6.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noports_core: ^6.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CurtlyCritchlow still need to change the noports_core dependency
Otherwise LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to update noports_core to 6.0.1
because I'm using "^" before 6.0.0 it will use the latest which is 6.0.1. Do you still want to explicitly use 6.0.1? |
In this case, best to pin to 6.0.1 |
@gkc plese review to unblock merge. |
- What I did
Fixes #758
Fixes #709
- How I did it
- How to verify it
- Description for the changelog