Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

758 provide more useful messages in the UI when a session is being created #764

Conversation

CurtlyCritchlow
Copy link
Contributor

- What I did
Fixes #758
Fixes #709
- How I did it

  • Used progressStream to provide user with useful messages in the UI
  • Added authenticateClientToRvd, authenticateDeviceToRVD and encryptedRvdTraffic to the profile form
  • Updated tooltip message use same message as the cli for Sshnp arguments

- How to verify it

  1. Run the app
  2. navigate to profile form screen, the new form screen should be present
  3. try to ssh, the terminal screen should display more useful information to the user.

- Description for the changelog

  • Updated profile form
  • updated messages shows to user during ssh

@XavierChanth
Copy link
Member

XavierChanth commented Jan 29, 2024

@CurtlyCritchlow

While it makes sense to say "when false, <negative effects>" for the CLI because they are on by default. In the UI we should always use the positive: "when turned on, <positive effects>" since we have a visual indication showing that these are on.

@@ -31,12 +31,12 @@ dependencies:
intl: any
macos_ui: ^2.0.0
mocktail: ^1.0.0
noports_core: ^5.0.0
noports_core: ^6.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noports_core: ^6.0.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CurtlyCritchlow still need to change the noports_core dependency

XavierChanth
XavierChanth previously approved these changes Jan 29, 2024
@XavierChanth
Copy link
Member

Otherwise LGTM

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to update noports_core to 6.0.1

@CurtlyCritchlow
Copy link
Contributor Author

CurtlyCritchlow commented Jan 30, 2024

Still need to update noports_core to 6.0.1

because I'm using "^" before 6.0.0 it will use the latest which is 6.0.1. Do you still want to explicitly use 6.0.1?

@XavierChanth
Copy link
Member

Still need to update noports_core to 6.0.1

because I'm using "^" before 6.0.0 it will use the latest which is 6.0.1. Do you still want to explicitly user 6.0.1?

In this case, best to pin to 6.0.1

@CurtlyCritchlow
Copy link
Contributor Author

@gkc plese review to unblock merge.

@gkc gkc merged commit 70bc342 into trunk Jan 30, 2024
6 checks passed
@gkc gkc deleted the 758-provide-more-useful-messages-in-the-ui-when-a-session-is-being-created branch January 30, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants