Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated dependencies and fixed analyzer issues #767

Merged
merged 2 commits into from Jan 30, 2024
Merged

Conversation

purnimavenkatasubbu
Copy link
Member

@purnimavenkatasubbu purnimavenkatasubbu commented Jan 30, 2024

- What I did

  • Updated dependencies of at_client, at_onboarding_cli, at_chops, at_lookup,at_utils, at_commons
  • Fixed lint errors related to value assertions:
    • Stopped checking whether AtKey.key or AtKey.metadata are null
    • Removed null check '?'

- How I did it

- How to verify it

  • noports_core Unit tests for lint errors and type errors
  • e2e tests for any functional errors

- Description for the changelog

Updated dependencies of at_client, at_onboarding_cli, at_chops, at_lookup,at_utils, at_commons

@@ -18,7 +18,7 @@ class SshnpDartPureImpl extends SshnpCore
atClient: atClient,
params: params,
sessionId: sessionId,
namespace: this.namespace,
namespace: namespace,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously, namespace was being masked by at_constants

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gkc gkc merged commit 2f16062 into trunk Jan 30, 2024
6 checks passed
@gkc gkc deleted the update_dependencies branch January 30, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants