Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bool fields remains the value the user selected #778

Conversation

CurtlyCritchlow
Copy link
Contributor

- What I did
Allow bool field in the profile form to reuse the user previously provide value instead of the default.
- How I did it
Updated the submit method to reuse the oldConfig values instead on the default SshnpParams value.
- How to verify it

  1. Run the app
  2. Edit a profile bool fields multiple time, the value should always remain as what you selected.

- Description for the changelog

bool field in the profile form to reuse the user previously provide value instead of the default.

@XavierChanth XavierChanth merged commit ec30d49 into trunk Jan 31, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile boolean fields resorts to the default value when the submit button is pressed sometimes
2 participants