Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: have the daemon support multiple manager atSigns #804

Merged
merged 7 commits into from Feb 8, 2024
Merged

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Feb 7, 2024

- What I did

  • feat: have daemon support multiple manager atSigns
    • made managerAtsign into a list and renamed to managerAtsigns in Sshnpd, SshnpdImpl and SshnpdParams
    • changed the long arg name for the managerAtsigns to managers but preserved manager as an alias
    • modified SshnpdImpl.isFromAuthorizedAtsign accordingly
    • extracted the username sharing code into its own function called from SshnpdImpl.run
    • modified the username and device_info sharing functions to iterate through the manager atSigns and share (or un-share) with each one
  • dependency management
  • bug fixes
    • fix: set ccd (cached cascade delete) for the username and device_info so that if they are un-shared then their cached copies are deleted from the manager atSigns
    • fix: sshnp client: sshnpd_channel: resolveRemoteUsername was correctly detecting if remote username had not been shared, but was actually returning null rather than (as intended) throwing an SshnpError

…y detecting if remote username had not been shared, but was actually returning null rather than (as intended) throwing an SshnpError
- made `managerAtsign` into a list and renamed to `managerAtsigns` in Sshnpd, SshnpdImpl and SshnpdParams
- changed the long arg name for the managerAtsigns to `managers` but preserved `manager` as an alias
- modified SshnpdImpl.isFromAuthorizedAtsign accordingly
- extracted the username sharing code into its own function called from SshnpdImpl.run
- modified the username and device_info sharing functions to iterate through the manager atSigns and share (or un-share) with each one
- set ccd (cached cascade delete) for the username and device_info so that if they are un-shared then their cached copies are deleted from the manager atSigns
# Conflicts:
#	packages/dart/sshnp_flutter/pubspec.lock
#	packages/dart/sshnp_flutter/pubspec.yaml
… at_lookup to latest so no dependency conflicts with latest noports_core which uses at_chops ^2.0.0 and at_commons ^4.0.0
@gkc
Copy link
Contributor Author

gkc commented Feb 7, 2024

@XavierChanth fyi for the c daemon

Copy link
Member

@cconstab cconstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gary works as expected under manual testing.. TY

@gkc gkc merged commit 8071b5e into trunk Feb 8, 2024
6 checks passed
@gkc gkc deleted the feat/800 branch February 8, 2024 04:49
@gkc gkc mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants