fix: Correct handling of mixed-case device names

[gkc]

- What I did

• fix: Updated device name validation : now require alphanumeric snake case
• feat: Increased max length of device name to 36
• feat: Use the same device name validation in all relevant constructors
• docs: Updated docs to include device_name constraints (alphanumeric snake case, max length 36)
• resolves sshnp/sshnpd -d option does not handle capitalisation of device names  #839

- How I did it

• modified regex in validation_utils.dart to be alphanumeric snake case, max length 36
• modified various programs' args parsing to validate device names using the same validation function
• modified various programs' args help to use the same language for describing the device name format
• Added unit tests for invalid device names
• Modified other unit tests to use valid device names

- How to verify it
Tests pass

[gkc]

• Changed validation regex for device name to alphanumeric snake case, max length 30
• Have all relevant constructors assert valid device name using the same validation function
• Modified installation docs to include device name format info
• Modified various program args to include consistent device name format help

[XavierChanth]

LGTM.
I had mentioned making it 36 characters so that someone using uuid v4s to manage their devices could do:

sshnpd -d "$(echo $uuid | sed 's/-/_/g')" ...

But this is still better than what we had before. There are some people who may be using uppercase device names as well, so it might be good if sshnpd automatically converts the device name input to lower case and emits a warning. This way upgrading is non-breaking

[gkc]

LGTM. I had mentioned making it 36 characters so that someone using uuid v4s to manage their devices could do:

sshnpd -d "$(echo $uuid | sed 's/-/_/g')" ...

But this is still better than what we had before. There are some people who may be using uppercase device names as well, so it might be good if sshnpd automatically converts the device name input to lower case and emits a warning. This way upgrading is non-breaking

Updated to 36 length

Given that the daemon does not currently work properly when using uppercase device names, I'd rather avoid any potential future confusion / bugs and have strict validation requiring lowercase

[cconstab]

Observation: Connected appears in the command line then an error message. I would have expected syntax to be checked before connection was made. Does not break anything just felt unexpected..
e.g.

╰$ ./npt -f @cconstab -t @ssh_1 -d ser-valan -l 9000 -r @rv_am -p 3389                            
Connecting ... Connected
Version : 5.0.3 (core: 6.0.4)
-f, --from (mandatory)                       This client's atSign
-t, --to (mandatory)                         The device daemon's atSign
-r, --srvd (mandatory)                       The socket rendezvous's atSign
-d, --device (mandatory)                     Receiving device name. Alphanumeric snake case, max length 36.
-l, --local-port,--lp                        client-side local port for the socket tunnel. If not supplied, we will
                                             ask the o/s for a spare port
                                             (defaults to "0")
-p, --remote-port,--rp (mandatory)           The remote port required
-h, --remote-host,--rh                       The remote host required
                                             (defaults to "localhost")
-k, --key-file,--keyFile                     Path to this client's atSign's keyFile, if not in ~/.atsign/keys/
    --root-domain                            atDirectory domain
                                             (defaults to "root.atsign.org")
    --[no-]per-session-storage,--[no-]pss    Use ephemeral local storage for each session. Defaults to true,
                                             enabling you to run multiple local clients concurrently. However: if
                                             you wish to run just one client at a time, then you will get a
                                             performance boost if you negate this flag.
                                             (defaults to on)
-v, --verbose                                More logging
    --help                                   Print usage
-x, --output-execution-command               Instead of running the srv in the same process, fork the srv, print
                                             the local port to stdout, and exit this program.

Invalid argument(s): Device name must be alphanumeric snake case, max length 36
2024-02-29 15:52:31.423678 : Cleaning up temporary files

[gkc]

Yeah that's naff. Will fix

[gkc]

[cconstab] Observation: Connected appears in the command line then an error message. I would have expected syntax to be checked before connection was made. Does not break anything just felt unexpected

[gkc] Yeah that's naff. Will fix

@cconstab fixed