Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add noports_core package #502

Merged
merged 5 commits into from Sep 27, 2023
Merged

refactor: add noports_core package #502

merged 5 commits into from Sep 27, 2023

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Sep 26, 2023

- What I did

  • split sshnoports into the current package and noports_core which will contain the decoupled core code.
  • Removed cli dependent code from it by doing the following:
    • No longer generating atClient in the library instead accepting either an AtClient or AtClient generator function
    • Added an option usageCallback function which gets called when the usage should be called for the CLI

(Looks like a lot of changes, but it's mostly just import renames)

FYI this package needs a README to be written still, but it is enough to progress with the demo applications that need to be created using the code. The README will be written before publishing the package (since pub.dev won't let you publish without it)

- How I did it

- How to verify it

- Description for the changelog
refactor: add noports_core package

Copy link
Contributor

@gkc gkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @XavierChanth

@gkc gkc merged commit c3e0122 into trunk Sep 27, 2023
12 checks passed
@gkc gkc deleted the noports_core branch September 27, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants