chore: Release v4.0.0 #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierChanth
commented
Dec 5, 2023
| description: "Run x64 builds only" | ||
| required: true | ||
| default: false | ||
| type: boolean |
There was a problem hiding this comment.
Added this to speed up the ability to confirm/test x64 releases, since non-x64 releases can take up to 10x longer
XavierChanth
commented
Dec 5, 2023
| if is_root & ! [ -f "$user_bin_dir/$1" ] ; then | ||
| ln -sf "$dest/$1" "$user_bin_dir/$1" | ||
| echo "Linked $user_bin_dir/$1 to $dest" | ||
| fi |
There was a problem hiding this comment.
If the binaries were installed as root, we need to do a symbolic to where the binaries were installed, since we install the binaries to /usr/local/bin if we are root
XavierChanth
commented
Dec 5, 2023
| dest="$user_bin_dir/$job_name.sh" | ||
| if ! [ -f "$dest" ]; then | ||
| cp "$script_dir/headless/$job_name.sh" "$dest" | ||
| fi |
There was a problem hiding this comment.
Make necessary folders, and don't overwrite existing job scripts when reinstalling
XavierChanth
commented
Dec 5, 2023
| pids=$(pgrep "$command") | ||
| if [ -n "$pids" ]; then | ||
| echo "$pids" | xargs kill | ||
| fi |
There was a problem hiding this comment.
Only call the kill command if there are processes to kill
gkc
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Cleaned up all remaining odds and ends:
- How I did it
- How to verify it
- Description for the changelog
chore: Release v4.0.0