fix: change list-devices back to flag type #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump version / release PRs will follow once this is approved and merged. |
cpswan
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #625
- What I did
--list-devicesfrom a string option back to a boolean flag@gkc @cpswan this is a breaking change, but it is unbreaking something that was accidentally broken when we pushed v4.0.0. I think we should push this out as noports_core (the sdk) version 5.0.0 but sshnoports (the cli) can be a patch increase 4.0.2 -> 4.0.3.
- How I did it
- How to verify it
- Description for the changelog
fix: change list-devices back to flag type