Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure terminal size is sane if it is currently 0x0 #1439

Open
krader1961 opened this issue Nov 15, 2019 · 0 comments
Open

Ensure terminal size is sane if it is currently 0x0 #1439

krader1961 opened this issue Nov 15, 2019 · 0 comments

Comments

@krader1961
Copy link
Contributor

Long ago I fixed a zero day bug in the fish shell triggered if the termios rows and column values are both zero. Such as can happen if using a Linux serial console. If the size is 0x0 (rows by columns) assume the size is 24x80 (for historical reasons). When this is implemented we can remove these lines from the expect based unit tests:

# Terminal rows and columns may default to zero so ensure sane values.
send "stty rows 24 cols 80\r"
expect_prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant