Remove var viraw
#865
Closed
Remove var viraw
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on lint cleanups I noticed that viraw is now a constant thanks to oclint warning about constant if() expressions. We no longer support the vi CLI editor mode without support for putting the tty in "raw" mode. So eliminate the symbol. And update the documentation to explain that the option no longer has any effect. Fixes #864
siteshwar
reviewed
Sep 12, 2018
| @@ -19,6 +19,7 @@ None at this time. | |||
|
|
|||
| ## Notable non-backward compatible changes | |||
|
|
|||
| - Vi raw mode is now the default and cannot be disabled (issue #864). | |||
There was a problem hiding this comment.
It does not look like a backward incompatible change to me. I see this entry in RELEASE file:
01-11-26 +The default has compilation mode has been changes so that
viraw mode will always be on.
I can not disable viraw mode in version of ksh that is shipped with RHEL.
There was a problem hiding this comment.
Note that "the default compilation mode" simply means that viraw was enabled by default. The second clause of that sentence seems to be independent of the first clause. And looking at the source in the legacy ast.master and ast.beta branches it is not at all obvious you can't disable viraw behavior. Nonetheless, I'm happy to move this statement about viraw to the "Other significant changes" section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on lint cleanups I noticed that viraw is now a constant
thanks to oclint warning about constant if() expressions. We no longer
support the vi CLI editor mode without support for putting the tty in
"raw" mode. So eliminate the symbol. And update the documentation to
explain that the option no longer has any effect.
Fixes #864