Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on Jeweler and user Rspec 2 #6

Merged
merged 4 commits into from Jun 1, 2011
Merged

Remove dependence on Jeweler and user Rspec 2 #6

merged 4 commits into from Jun 1, 2011

Conversation

plukevdh
Copy link
Contributor

I dislike jeweler. Bundler's gem generator is a hell of a lot cleaner. Also, rspec 2 plz.

  • Updated gemspec to use bundler's conventions.
  • Updated specs/config to use RSpec 2
  • Fixed specs with possible API changes
  • Added all the necessary dependencies.
  • Added Gemfile to allow devs to get up to speed easily.

THIS REQUEST ENCOMPASSES OTHER REQUEST AS WELL. NOT SURE HOW TO SCOPE MY PULL REQUEST TO COMMITS AFTER MY OTHER COMMITS. GITHUB FAIL.

@plukevdh
Copy link
Contributor Author

If you don't like my removal of Jeweler, feel free to close/reject. Just figured it make future collab easier.

attack added a commit that referenced this pull request Jun 1, 2011
Remove dependence on Jeweler and user Rspec 2
@attack attack merged commit c765c91 into attack:master Jun 1, 2011
@plukevdh
Copy link
Contributor Author

plukevdh commented Jun 1, 2011

very pleased you pulled this one. thanks so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants