Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APP-2866] Update iOS Privacy Policy based on new requirements from Apple #81

Closed
wants to merge 3 commits into from

Conversation

vespinola
Copy link
Contributor

@vespinola vespinola commented May 10, 2024

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Jira Link

What's new?

Added PrivacyInfo.xcprivacy to include a description of usages of UserDefaults within the SDK. As per Apple Documentation, CA92.1 included since it is not modifying any other external App data.

Bumped version to 0.5.1.

Note: These changes are for SPM only.

Testing

  • Generated XCFramework to verify if the .xcpricacy is included in the framework bundle
  • Integrated into the Sample App with SPM to verify if the .xcpricacy exists as well.

// Iphone Device Archive 
xcodebuild archive \
-scheme attentive-ios-sdk-framework \
-configuration Release \
-destination 'generic/platform=iOS' \
-archivePath './build/attentive-ios-sdk-framework.framework-iphoneos.xcarchive' \
SKIP_INSTALL=NO \
BUILD_LIBRARIES_FOR_DISTRIBUTION=YES

// Simulator Archive 
xcodebuild archive \
-scheme attentive-ios-sdk-framework \
-configuration Release \
-destination 'generic/platform=iOS Simulator' \
-archivePath './build/attentive-ios-sdk-framework.framework-iphonesimulator.xcarchive' \
SKIP_INSTALL=NO \
BUILD_LIBRARIES_FOR_DISTRIBUTION=YES

// Generate XCFramework
xcodebuild -create-xcframework \
-framework './build/attentive-ios-sdk-framework.framework-iphoneos.xcarchive/Products/Library/Frameworks/attentive_ios_sdk_framework.framework' \
-framework './build/attentive-ios-sdk-framework.framework-iphonesimulator.xcarchive/Products/Library/Frameworks/attentive_ios_sdk_framework.framework' \
-output './build/attentive-ios-sdk-framework.xcframework'

Screenshots

XCFramework generated by scripts

Screenshot 2024-05-13 at 9 33 06 AM

SPM Integration with custom branch

Screenshot 2024-05-13 at 9 34 05 AM

@vespinola vespinola added the bug Something isn't working label May 13, 2024
@vespinola vespinola self-assigned this May 13, 2024
@vespinola vespinola added the SPM label May 13, 2024
@vespinola vespinola marked this pull request as ready for review May 13, 2024 15:29
@vespinola
Copy link
Contributor Author

Moving this PR to Draft again until we figure out how to maintain SPM & Cocoapods

@vespinola vespinola marked this pull request as draft May 13, 2024 18:25
@vespinola
Copy link
Contributor Author

Changes will be added to other PR.
Closing this one.

@vespinola vespinola closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.5.1 bug Something isn't working SPM
Development

Successfully merging this pull request may close these issues.

None yet

1 participant