Logging with --no-colors outputting objects #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of pointing to our forks, isn't it better if we ask developers to publish a new version on npm? |
|
Yep in the ideal world it'll be better, but with using forks we are not blocked by other people. We can update our deps back to point to npm as soon as the new versions are released. Asked here: Marak/colors.js#36 |
The issue here was that when logging from Attester with `--no-colors` passed in command line, it sometimes logged the String object (console.dir fashion) instead of a logging a string literal (precisely it was fixed by Marak/colors.js@5ca667d). Close attester#48.
|
0.6.1 has been released in npm, I checked it and it looks fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colors.js hasn't been updated in npm for a long time but it's being updated on Github.
The issue here was that when logging from Attester with
--no-colorspassed in command line, it sometimes logged the String object (console.dirfashion) instead of a logging a string literal (precisely it was fixed by Marak/colors.js@5ca667d).