Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pointers with references where applicable #9

Closed
attilammagyar opened this issue May 10, 2023 · 0 comments
Closed

Replace pointers with references where applicable #9

attilammagyar opened this issue May 10, 2023 · 0 comments
Assignees
@attilammagyar
Labels
code cleanup Readability, CPU utilization, debuggability, compilation time improvements, etc.

Comments

@attilammagyar
Copy link
Owner

As @ZonderP pointed out in issue #6, some of the changes that were introduced for VST 3 aren't actually needed, like passing the Synth by pointer instead of reference to ImportPatchButton, Serializer, and co. E.g. 98f4354

These should be undone.
@attilammagyar attilammagyar added the code cleanup Readability, CPU utilization, debuggability, compilation time improvements, etc. label May 10, 2023
@attilammagyar attilammagyar self-assigned this May 10, 2023
@attilammagyar attilammagyar mentioned this issue May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attilammagyar attilammagyar

Labels
code cleanup Readability, CPU utilization, debuggability, compilation time improvements, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@attilammagyar