Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add double quote to Webpack output path argument #92

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: add double quote to Webpack output path argument #92

wants to merge 3 commits into from

Conversation

dvaJi
Copy link

@dvaJi dvaJi commented Sep 4, 2019

It adds a double quote to avoid an error with whitespaces in the path.
Example of the path: C:\My projects\searchui

@klk1010 klk1010 changed the base branch from master to develop September 18, 2019 19:45
@klk1010 klk1010 added this to the v1.0.9 milestone Sep 20, 2019
@klk1010 klk1010 modified the milestones: v5.6.4, 5.6.5 Oct 4, 2019
luigivaldez
luigivaldez approved these changes Oct 15, 2019
View reviewed changes
Copy link
Collaborator

@luigivaldez luigivaldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigivaldez luigivaldez luigivaldez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvaJi @luigivaldez @klk1010