Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install of pygame on Python 3.11 #164

Merged
merged 3 commits into from Nov 17, 2022
Merged

Fix install of pygame on Python 3.11 #164

merged 3 commits into from Nov 17, 2022

Conversation

PeterJCLaw
Copy link
Contributor

@PeterJCLaw
Copy link
Contributor Author

CI failures are due to mypy issues, which are explored separately in #161

@attwad
Copy link
Owner

attwad commented Nov 17, 2022

3.7 seems to be unhappy about that change no?
https://github.com/attwad/python-osc/actions/runs/3487223249/jobs/5834596260

@PeterJCLaw
Copy link
Contributor Author

PeterJCLaw commented Nov 17, 2022 •
edited

Hrm, I'm not sure there's a version of pygame which supports old and new Python :(
Pinning mypy for now is looking more appealing (but doesn't solve Python 3.11).

@PeterJCLaw
Copy link
Contributor Author

Ok, I think pygame is happy now -- we're back to the original mypy errors I think.

@PeterJCLaw PeterJCLaw mentioned this pull request Nov 17, 2022
Merged
@attwad attwad merged commit b8c647b into attwad:master Nov 17, 2022
@PeterJCLaw PeterJCLaw deleted the fix-python-3.11-ci-pygame-install branch November 17, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterJCLaw @attwad