-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation suggests "keymap_mode" exists but it's not in the config #1625
Comments
As far as I run the same command, it's in the config. [murase@chatoyancy 0 atuin]$ atuin default-config | grep keymap_mode
# keymap_mode = "auto" Which version of |
Yep, this is currently only on
The documentation should probably be versioned, I'll add it to the todo |
Then that would explain it, because I just installed ❯ atuin --version
atuin 17.2.1 I figured this was a known thing. However, the docs are also out of sync with the default value of Anyway if this is already on the devs' radar, I will close the issue. Thanks for the lightening fast replies! |
Thanks! The docs for enter_accept are accurate
We prefill enter_accept as true for new users. If it is absent, it defaults to false This means we wouldn't change the behaviour for existing users, as it's quite a big change |
Sorry, I guess I was unclear. I just meant that as I was skimming the docs yesterday top to bottom, for
This initially confused me, because it was inconsistent with my local default. But then I read further and saw that the docs already acknowledge this discrepancy. (Maybe you could put an asterisk there or something? "Default: By contrast, the discrepancy between docs and reality for But anyway, I see that it's coming, not an oversight. So we're in the clear 👍 |
Commit b8c6b9a corresponds to the widget name change introduced in atuinsh/atuin#1631. Also, the current documentation diverges from the current implementation. I updated the widgets for the <kbd>up</kbd> key in commit 6e1f3df. Also, the descriptions for the newly added widgets for `keymap_mode` (atuinsh/atuin#1570) are added in commit 705214a. Since the version dependence of documentation can confuse people as in atuinsh/atuin#1625, I decided to add a note on the version dependence and also a required version for each feature. I personally think it is useful to maintain in the documentation the minimal version requirement for each feature, but this might be the perspective of a developer who needs to consider the compatibility of products with arbitrary versions of other products. If you have a different preference, please tell me that. There is an extra commit 33a1d6d. Sorry, this is unrelated to the widget name but a tiny clarification of a description I added in my previous PR #10. If I should submit a change in a separate PR, please tell me that. It's a small change, but I'll create a separate one if you'd prefer it.
The documentation states
However, the config actually appears to expose no such parameter:
This seems like a giant oversight, so it makes me wonder whether I'm missing something, or else whether the missing parameter is a known thing. But searching the current issues for
keymap_mode
and returns nothing, hence this issue feels justified.The text was updated successfully, but these errors were encountered: