-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve some issues with install.sh #188
Conversation
I should probably wait for the dependabot PRs to be merged. |
Why does But now it works again. I just re-ran it. EDIT: |
Could you share the logs from the failures please? Maybe some of the env var stuff is being non deterministic |
EDIT: Added Backtrace |
Some people don't use sudo or have curl, sed or wget installed by default. This adds a check, if sudo, curl and sed are installed and changes wget to curl as this is the mostly used command in the script. If sudo is not installed it uses su. Closes: atuinsh#175
The printf was missing a newline at the end, which resulted in the eval line being appended directly to the end of the previous line.
0fb2b91
to
3c7ed95
Compare
Yay. The test finished successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic, thank you for your work here! 💖
Thanks |
Some people don't use sudo or have curl, sed or wget installed by default.
This adds a check, if sudo, curl and sed are installed and changes wget
to curl as this is the mostly used command in the script. If sudo is not
installed it uses su.
The printf was missing a newline at the end, which resulted in the eval
line being appended directly to the end of the previous line. This is
similar to the problem from #56.
Closes: #175