Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dotfiles): alias import with init output #1970

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix(dotfiles): alias import with init output #1970

merged 1 commit into from
Apr 22, 2024

Conversation

ellie
Copy link
Member

@ellie ellie commented Apr 22, 2024

Ref #1953

Added a test case and fix

cc @rigrig, does this resolve the issue for you?

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@ellie ellie merged commit d239a67 into main Apr 22, 2024
17 checks passed
@ellie ellie deleted the ellie/alias-fix branch April 22, 2024 09:32
@rigrig
Copy link
Contributor

rigrig commented Apr 22, 2024

Actually...
I didn't pay a lot of attention when reporting that: I just deleted all aliases from my db to fix the problem, and the fortune was the obvious breakage.
But looking at the code now, it looks broken in another way: Fish alias output doesn't include a = sign, so it would just be e.g.:

alias emacs 'TERM=xterm-24bits emacs -nw --foo=bar'
alias k kubectl

(Fish allows setting them both ways though: both alias k=kubectl and alias k kubectl work)

@ellie
Copy link
Member Author

ellie commented Apr 22, 2024

Ah I see! Well that needed fixing anyway, glad it's done.

#1972 should sort that

@rigrig
Copy link
Contributor

rigrig commented Apr 22, 2024

Urgh, it's still sometimes broken now: some ASCII art contains =...
I guess maybe it could redirect the alias output to a file and read that? But that seems like a lot of effort 😞

I don't really mind having to turn off the script for the initial import, and I (only just) figured out I can just atuin dotfiles alias delete those stray "aliases", instead of messing with the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants