Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic when the setup isn't done #653

Closed
jjant opened this issue Dec 22, 2022 · 2 comments · Fixed by #654
Closed

Don't panic when the setup isn't done #653

jjant opened this issue Dec 22, 2022 · 2 comments · Fixed by #654

Comments

@jjant
Copy link

jjant commented Dec 22, 2022

I just heard of atuin, went to try it and got a panic:

❯ atuin
fish: Unknown command: atuin
❯ nix shell nixpkgs#atuin
❯ atuin search
thread 'main' panicked at 'failed to find ATUIN_SESSION - check your shell setup: NotPresent', atuin-client/src/database.rs:30:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

The error message is clear but it'd be a bit nicer that it didn't panic.

@ellie
Copy link
Member

ellie commented Dec 22, 2022

Sure, we could definitely make this a bit neater!

Although, the error message does sum up what needs doing

failed to find ATUIN_SESSION - check your shell setup: NotPresent

your shell setup is not correct

@jjant jjant changed the title Display better error message when setup isn't done Don't panic when the setup isn't done Dec 22, 2022
@jjant
Copy link
Author

jjant commented Dec 22, 2022

Yes, you're right, I edited the issue to reflect that ⭐

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants