Enable multiple command stats to be shown #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add improved pipe splitting Clean up split logic Remove unnecessary lifetime annotations Add per-column command padding
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey! Thank you for working on this 🙏 Generally looks good, though I found an issue with unicode.
As mentioned there, we will probably need to use something like unicode_segmentation instead. I hope you don't mind me pushing to your branch, but I've added a failing test case to highlight the issue |
drbrain
added a commit
to drbrain/atuin
that referenced
this pull request
Feb 20, 2024
This addresses feedback in PR atuinsh#1054 Closes atuinsh#1054
2 tasks
ellie
added a commit
that referenced
this pull request
Feb 26, 2024
…egmentation (#1739) * Enable multiple command stats to be shown Add improved pipe splitting Clean up split logic Remove unnecessary lifetime annotations Add per-column command padding * Add failing test case * Update #1054 to use unicode_segmentation This addresses feedback in PR #1054 Closes #1054 * Address cargo clippy, fmt --------- Co-authored-by: Sorenson Stallings <contact@sorenson.dev> Co-authored-by: Ellie Huxtable <ellie@elliehuxtable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes extend the
statssubcommand with an--ngram-sizeargument, which supports providing statistics for combinations of commands. I have found this useful for identifying the most common combinations of commands as candidates for further automation.