Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nu section in key-bindings.md - set-env -> let-env #1074

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix nu section in key-bindings.md - set-env -> let-env #1074

merged 1 commit into from
Jun 26, 2023

Conversation

eopb
Copy link
Contributor

@eopb eopb commented Jun 25, 2023

I don't think set-env exists 🤔

❯ : set-env ATUIN_NOBIND = true
Error: nu::shell::external_command

  × External command failed
   ╭─[entry #6:1:1]
 1 │ set-env ATUIN_NOBIND = true
   · ───┬───
   ·    ╰── did you mean 'let-env'?
   ╰────
  help: No such file or directory (os error 2)

@eopb
Update nu section in key-bindings.md - set-env -> let-env
3889bfa 
I don't think `set-env` exists 🤔 

```
❯ : set-env ATUIN_NOBIND = true
Error: nu::shell::external_command

  × External command failed
   ╭─[entry atuinsh#6:1:1]
 1 │ set-env ATUIN_NOBIND = true
   · ───┬───
   ·    ╰── did you mean 'let-env'?
   ╰────
  help: No such file or directory (os error 2)
```
@vercel
Copy link

vercel bot commented Jun 25, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 8:05pm

@conradludgate
Copy link
Collaborator

Can you triple check what version of nu you are running? Other has nu made yet another breaking change 😭?

@eopb
Copy link
Contributor Author

eopb commented Jun 26, 2023

Can you triple check what version of nu you are running? Other has nu made yet another breaking change 😭?

I'm running 0.81.0 which is the latest version. The extra weird thing is that I can't find a reference to set-env anywhere in the changelogs.

ellie
ellie approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also couldn't find anything about a breaking change, but this is at least presently correct

@conradludgate
Copy link
Collaborator

Oh, this is only in our readme? I guess I never tested that personally and I assume it was a typo from the beginning. Our init script has used let-env for a while

@ellie
Copy link
Member

ellie commented Jun 26, 2023

Yeah I guess it must have been a typo from day one!

@ellie
Copy link
Member

ellie commented Jun 26, 2023 •
edited

anyways, thanks for fixing @eopb

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie merged commit 0ca72ee into atuinsh:main Jun 26, 2023
9 checks passed
@eopb eopb deleted the patch-1 branch June 26, 2023 09:03
ealap pushed a commit to ealap/atuin that referenced this pull request Jun 29, 2023
@eopb @ealap
Update nu section in key-bindings.md - set-env -> let-env (at…
0a3312b 
…uinsh#1074)

I don't think `set-env` exists 🤔 

```
❯ : set-env ATUIN_NOBIND = true
Error: nu::shell::external_command

  × External command failed
   ╭─[entry atuinsh#6:1:1]
 1 │ set-env ATUIN_NOBIND = true
   · ───┬───
   ·    ╰── did you mean 'let-env'?
   ╰────
  help: No such file or directory (os error 2)
```
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellie ellie ellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eopb @conradludgate @ellie