Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.toml path default comments #1092

Merged
merged 1 commit into from
Jul 8, 2023
Merged

Update config.toml path default comments #1092

merged 1 commit into from
Jul 8, 2023

Conversation

simon-b
Copy link
Contributor

@simon-b simon-b commented Jul 8, 2023

  • Updates outdated mac db_path default
  • Adds windows db_path default
  • Adds windows, mac, linux defaults for key_path and session_path
  • Changes example session_path to be different to example key_path

Closes #1091

@simon-b
Update config.toml path default comments
9ddc0d6 
- Updates outdated mac db_path default
- Adds windows db_path default
- Adds windows, mac, linux defaults for key_path and session_path
- Changes example session_path to be different to example key_path
@vercel
Copy link

vercel bot commented Jul 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2023 9:35pm

ellie
ellie approved these changes Jul 8, 2023
View reviewed changes
Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting this out! 🙌

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie enabled auto-merge (squash) July 8, 2023 22:37
@ellie ellie merged commit a6c4f2c into atuinsh:main Jul 8, 2023
9 checks passed
@simon-b simon-b deleted the update_default_config branch July 9, 2023 00:37
ealap pushed a commit to ealap/atuin that referenced this pull request Jul 18, 2023
@simon-b @ealap
Update config.toml path default comments (atuinsh#1092)
e117aac 
- Updates outdated mac db_path default
- Adds windows db_path default
- Adds windows, mac, linux defaults for key_path and session_path
- Changes example session_path to be different to example key_path
@ZhongRuoyu ZhongRuoyu mentioned this pull request Aug 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellie ellie ellie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default OS X db_path does not match the comment in default config.toml
2 participants
@simon-b @ellie