Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Ctrl-n instead of Alt-n on macOS #1106

Merged
merged 2 commits into from Jul 27, 2023
Merged

Conversation

zygous
Copy link
Contributor

@zygous zygous commented Jul 16, 2023

To use alt-n modifiers on macOS the user must configure their terminal emulator to map option to alt. This isn't obvious -- hence issues have been raised here about those shortcuts not working -- but, moreover, doing so prevents option-3 being used to type # on British Macs.

This change adds a configuration option ctrl_n_shortcuts, set false by default, that replaces the numerical shortcuts alt-n with ctrl-n ones.

This PR only adds ctrl-n support, where n is a number: it does not affect the alt-b or alt-f shortcuts.

@vercel
Copy link

vercel bot commented Jul 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 7:49pm

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

@ellie ellie enabled auto-merge (squash) July 27, 2023 07:58
@ellie ellie merged commit c044995 into atuinsh:main Jul 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants