fix(fish): clean up the fish script options #1370
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1368
I reviewed and updated the options we use in the fish script, fixing several issues:
--groups
option as reported in atuin reports an unknown option "-qg" for string match #1368, it's not needed if we're only testing whether the match exists.-l
, and removing the-x
(export) setting for ATUIN_HISTORY_ID as it's unnecessary. The non-local variables (s
,h
,hist
) were clobbering any user-defined variables with the same name.h
andhist
to have anATUIN_
prefix, as those variables are accessible from user-defined code. Without this, usingenter_accept
with the history itemecho $h
would have given the user the script value of$h
instead of their own.