Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zsh_autosuggest_strategy for no-unset environment #1486

Merged
merged 7 commits into from
Jan 2, 2024

Conversation

ds-cbo
Copy link
Contributor

@ds-cbo ds-cbo commented Jan 2, 2024

Fix some changes introduced in #1479 for environments with set -o nounset leading to the following error:

(eval):19: ZSH_AUTOSUGGEST_STRATEGY[@]: parameter not set

Somewhat related to #921 ... maybe we should add a test for this environment, though I'm unsure how easy that would be

(Should probably squash this merge, I had some issues bringing my fork back up to origin)

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 11:04am

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

maybe we should add a test for this environment

Absolutely. I'm not sure how easy that would be to do either, but for now I've just set my env so that I'll catch it in future. Not "scalable", but good enough for now

@ellie ellie enabled auto-merge (squash) January 2, 2024 11:48
@ellie ellie merged commit f44db9d into atuinsh:main Jan 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants