Skip to content

perf: optimize history init-store#1691

Merged
ellie merged 1 commit intomainfrom
ellie/perf1
Feb 12, 2024
Merged

perf: optimize history init-store#1691
ellie merged 1 commit intomainfrom
ellie/perf1

Conversation

@ellie
Copy link
Member

@ellie ellie commented Feb 9, 2024

Instead of lots of small sqlite transaction, do one monster one.

A single tx with 100s of 1000s of rows should be fine on all systems

A very unscientific test shows this to be roughly 10x faster

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

Instead of lots of small sqlite transaction, do one monster one.

A single tx with 100s of 1000s of rows should be fine on all systems

A very unscientific test shows this to be roughly 10x faster
@ellie ellie merged commit 8ef5f67 into main Feb 12, 2024
@ellie ellie deleted the ellie/perf1 branch February 12, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant