refactor(nushell): update commandline syntax, closes #1733

[stevenxxiu]

This should be merged when the next version of Nushell releases, where it'll change the commandline syntax.

Checks

• I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
• I have checked that there are no existing pull requests for the same thing

[fdncred]

The next nushell release is scheduled for 5th of March.

[arcuru]

Is it possible to check the Nushell version and support both versions?

[stevenxxiu]

I could do that, but this adds the additional burden of removing the code later down the track.

I feel like Nushell is still unstable, so people should update regularly anyway.

[fdncred]

Nushell does populate $env.NU_VERSION for an easy way to check the nushell version running. One can also do nu --version and get the same version string.

[arcuru]

Nushell itself is apparently going to support the old way for 1 release before deprecating. Some of Atuin's users may be on platforms where they aren't running the absolute latest Nushell.

This change as written will cause Atuin to deal with the Nushell breakage, as anyone on older versions of Nushell will not get an appropriate warning message and will think Atuin has the bug. That will be far more burden than removing the code down the line.

Nushell having breaking changes is fine, but all programs trying to work with Nushell, like Atuin, will be trying to support older versions where possible. Having a point in time where a user has to update both Nushell and Atuin at exactly the same time is unreasonable.

[stevenxxiu]

True. I suppose Atuin and Nushell won't always update at similar times.

I've added backwards compatibility for Nushell <= v0.90.

[stevenxxiu]

With the code being backwards compatible, this could probably be reviewed and merged before the Nushell release. If there's not more breaking changes on this front. @ellie @fdncred

[ellie]

lgtm, thank you!