Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify operation result for working with aliases #1748

Merged
merged 1 commit into from Feb 21, 2024

Conversation

Adda0
Copy link
Contributor

@Adda0 Adda0 commented Feb 21, 2024

This PR tries to clarify the info messages when working with aliases. No functional changes were made.

The delete message mentions which alias with which value was deleted so that the user can confirm that this is indeed the alias they wanted to remove. If not, they can reset it again. In case of an error, the error message format of rm is followed: problem: reason (rm: cannot remove 'file': No such file or directory).

The set alias message clearly separates the beginning and end of alias name=value from the normal text. Otherwise, one needs to parse the name=value with name=value2 where with blends in with the end of the value.

$ atuin config alias set m "make run"
# Change this:
Overwriting alias m=make with m=make run
# to this:
Overwriting alias 'm=make' with 'm="make run"'.

If the changes are not to your liking, feel free to modify or close the PR.

Checks

  • I am happy for maintainers to push small adjustments to this PR, to speed up the review cycle
  • I have checked that there are no existing pull requests for the same thing

@atuin-bot
Copy link

This pull request has been mentioned on Atuin Community. There might be relevant details there:

https://forum.atuin.sh/t/weekly-release-2024-08/192/7

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! thanks

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

@ellie ellie merged commit cf2cbd2 into atuinsh:main Feb 21, 2024
15 checks passed
@Adda0 Adda0 deleted the clarify_alias_value_end branch February 21, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants