Add TUI, resolve #19, #17, #16 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This totally removes the requirement for FZF! Also no longer lists all the database contents and pipes them to something, and instead uses SQLite for searching. Again, SQLite still needs optimizing! We're literally using a LIKE query here, and something like the FTS module would make more sense I think. On top of this, at the moment the TUI is very... "initial implementation". Ie, the code is a mess. It needs restructuring + rethinking, but it works :) I'd like to include more stats in the TUI at some point, without slowing it down too much!
conradludgate
approved these changes
Mar 20, 2021
Comment on lines
+63
to
+70
| Some(i) => { | ||
| if i == 0 { | ||
| 0 | ||
| } else { | ||
| i - 1 | ||
| } | ||
| } | ||
| None => 0, |
There was a problem hiding this comment.
Suggested change
| Some(i) => { | |
| if i == 0 { | |
| 0 | |
| } else { | |
| i - 1 | |
| } | |
| } | |
| None => 0, | |
| None | Some(0) => 0, | |
| Some(i) => i - 1, |
Comment on lines
+176
to
+181
| if let Some(selected) = app.results_state.selected() { | ||
| if selected == i { | ||
| content.style = | ||
| Style::default().fg(Color::Red).add_modifier(Modifier::BOLD); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| if let Some(selected) = app.results_state.selected() { | |
| if selected == i { | |
| content.style = | |
| Style::default().fg(Color::Red).add_modifier(Modifier::BOLD); | |
| } | |
| } | |
| if app.results_state.selected() == Some(i) { | |
| content.style = Style::default().fg(Color::Red).add_modifier(Modifier::BOLD); | |
| } |
|
(off topic) @conradludgate how in the world did you approve after the PR was merged...?! 😄 |
You can approve any PR post merge :) |
bl-ue
reviewed
May 7, 2021
There was a problem hiding this comment.
Really! I can't, and have never been able to, even on repos that I have write access to, e.g. https://github.com/tldr-pages/tldr 🤔
|
This pull request has been mentioned on Atuin Community. There might be relevant details there: https://forum.atuin.sh/t/question-about-usage-of-stderr-stdout-in-atuin-search-i/66/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This totally removes the requirement for FZF! Also no longer lists all
the database contents and pipes them to something, and instead uses
SQLite for searching. Again, SQLite still needs optimizing! We're
literally using a LIKE query here, and something like the FTS module
would make more sense I think.
On top of this, at the moment the TUI is very... "initial
implementation". Ie, the code is a mess. It needs restructuring +
rethinking, but it works :) I'd like to include more stats in the TUI at
some point, without slowing it down too much!
Also automatically search for whatever the current command buffer is.