Do not crash if the history timestamp is in the future #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellie
force-pushed
the
future-time
branch
2 times, most recently
from
dacd595
to
9c9e9dc
Compare
We were throwing an OutOfRangeError. This occurs when you attempt to convert to a duration, and your input is <0. A value in the future would have done this. This is especially noticeable during DST...
conradludgate
approved these changes
Dec 20, 2021
ellie
added a commit
that referenced
this pull request
Apr 12, 2022
f861893 Update to clap 3.1.x (#289) e8f7aac Add compact mode (#288) 1e04c4c Add rust-version to Cargo.toml (#287) 222e52b Update Dockerfile fae118a Improve fuzzy search (#279) 7cde55a Add code of conduct (#281) d270798 Update config-rs (#280) 3248883 Update README.md 7f58741 Fix `history list --cwd` errors (#278) e117b62 Update fish bindings. (#265) 4223ac6 Restore bash 4.2 compatibility, only add hook once (#271) 7651f89 Add support for blesh (#267) c2dd332 fix: get install.sh working on UbuntuWSL (#260) 84403a3 Bump reqwest from 0.11.7 to 0.11.9 (#261) 5005cf7 Bump serde_json from 1.0.73 to 1.0.75 (#262) 7fa3e1c Do not crash if the history timestamp is in the future (#250) 8d21506 use sqlite grouping rather than subquery (#181) d36ff13 Replace dpkg with apt (#248)
Merged
ellie
added a commit
that referenced
this pull request
Apr 12, 2022
f861893 Update to clap 3.1.x (#289) e8f7aac Add compact mode (#288) 1e04c4c Add rust-version to Cargo.toml (#287) 222e52b Update Dockerfile fae118a Improve fuzzy search (#279) 7cde55a Add code of conduct (#281) d270798 Update config-rs (#280) 3248883 Update README.md 7f58741 Fix `history list --cwd` errors (#278) e117b62 Update fish bindings. (#265) 4223ac6 Restore bash 4.2 compatibility, only add hook once (#271) 7651f89 Add support for blesh (#267) c2dd332 fix: get install.sh working on UbuntuWSL (#260) 84403a3 Bump reqwest from 0.11.7 to 0.11.9 (#261) 5005cf7 Bump serde_json from 1.0.73 to 1.0.75 (#262) 7fa3e1c Do not crash if the history timestamp is in the future (#250) 8d21506 use sqlite grouping rather than subquery (#181) d36ff13 Replace dpkg with apt (#248)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #189
We were throwing an OutOfRangeError. This occurs when you attempt to
convert to a duration, and your input is <0. A value in the future would
have done this. This is especially noticeable during DST...