Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ubuntu install #46

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix ubuntu install #46

merged 1 commit into from
May 7, 2021

Conversation

ismith
Copy link
Contributor

@ismith ismith commented May 7, 2021

The filename for the deb is versioned like '0.6.4', not 'v0.6.4'.

The filename for the deb is versioned like '0.6.4', not 'v0.6.4'.
@ismith
Copy link
Contributor Author

ismith commented May 7, 2021

I'm not sure how you are managing versioning/releases, so that's untouched.

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sorting this out! 💖

Could do with updating the artifact build so that the name matches the other artifacts (and has the v prefix), but I'm happy with this change as it fixes the current release.

@ellie ellie merged commit e2edcbf into atuinsh:main May 7, 2021
@ismith
Copy link
Contributor Author

ismith commented May 7, 2021

Yeah, fixing the name so all the versions match would be a fine solution as well, I just couldn't find where cargo (I assume) is configured to build the .deb.

Thanks for making this, it's what I've always wanted!

@ellie
Copy link
Member

ellie commented May 7, 2021

Yeah, fixing the name so all the versions match would be a fine solution as well, I just couldn't find where cargo (I assume) is configured to build the .deb.

In case anyone else is wondering, currently it's done here: https://github.com/ellie/atuin/blob/main/.github/workflows/release.yaml#L141

cargo-deb might have an option for setting the filename, otherwise I guess the pipeline could just rename it or something 🤷‍♀️

Thanks for making this, it's what I've always wanted!

Glad you like it! It's something I'd been meaning to make for a while haha

@ellie ellie mentioned this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants