Build ARM64 releases & update runners #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not entirely sure how to test this workflow. Why weren't ARM64 builds being made anyways? The workflow literally has cases to handle it! Fixes #369
Absolucy
commented
Nov 3, 2022
I very vaguely remember there being a case where a dependency wouldn't built for ARM, while on CI. ARM for mac was much newer then though |
ellie
approved these changes
Nov 3, 2022
Merged
|
I think I figured out why it failed: rust-lang/rust#28924 (comment) |
ohh interesting! we can try that for the next release then, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure how to test this workflow.
I updated the runners as the current ones being used are deprecated, and GitHub really seems to want people to move to newer ones.
I'm confused: why weren't ARM64 builds being made? The workflow literally has cases to handle it...
Fixes #369