Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Highlights results #630

Closed
wants to merge 1 commit into from

Conversation

jean-santos
Copy link
Contributor

@jean-santos jean-santos commented Nov 25, 2022

Hello!
I'm opening this PR to introduce the idea and get your opinion on this!

I started with the idea of highlighting the output for fzf (which I currently use), while at that, I saw that is possible to use the same strategy to highlight TUI output too. Though I'm not sure if I should keep both on the same PR.

What it is somewhat working right now:
atuin search --fzf-mode QUERY | fzf --ansi
--fzf-mode invert the order of the output (fzf style : the first line is the most relevant) and highlight the result's

image

The current tui atuin search -i
image

Update : I'm working on this again with the goal to only highlight on both tui and --cmd-only

@arcuru
Copy link
Sponsor Contributor

arcuru commented Nov 26, 2022

Coloring the interactive search TUI was requested in #503 as well. I think that is definitely a worthwhile change.

On the --fzf-mode change, it should probably be split into a separate PR unless the implementations are very interdependent.

@vercel
Copy link

vercel bot commented Apr 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 3:02pm

@nh2
Copy link
Contributor

nh2 commented May 6, 2023

This would be quite nice to have, skim has such highlights too.

@beyarkay
Copy link

Any progress on this? I'm happy to pick up what's left

@jean-santos
Copy link
Contributor Author

Any progress on this? I'm happy to pick up what's left

Apologies for the delayed response.
I'm busy lately and couldn't work on this PR. I'd be happy if someome could pick this up!

@beyarkay
Copy link

Writing a comment here as a check-in for where the branch currently is at, and what needs to be done.

Currently there is some partial highlighting:

(main on the bottom, branch on the top)
Screenshot 2023-06-21 at 11 02 58

But it doesn't look like there's fuzzy highlighting:

Screenshot 2023-06-21 at 11 04 45

So getting highlighting working for multiple spans of a command will be my first goal I think. I'll leave updates as I find other things to be done for this to be merged.

@ellie
Copy link
Member

ellie commented Jan 17, 2024

Hey! I'm going to close this one as it's pretty inactive. Happy to reopen should that change 🙏

@ellie ellie closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants