Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for zsh no-unset environments #921

Merged
merged 3 commits into from Jul 10, 2023
Merged

fix for zsh no-unset environments #921

merged 3 commits into from Jul 10, 2023

Conversation

ds-cbo
Copy link
Contributor

@ds-cbo ds-cbo commented Apr 26, 2023

When I run atuin init zsh in my zshrc, I am greeted with

_atuin_precmd:3: ATUIN_HISTORY_ID: parameter not set

any time I boot my shell, because I also have set -o nounset to tell me when I'm accidentally using variables that don't exist, for example because of a typo.

This makes sure that error doesn't happen

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
atuin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 8:57am

Copy link
Member

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh nice catch, thank you!

Seeing as this is your first time contributing, if you would like a holographic contributors-only Atuin sticker, then please fill out this form!

We do also have a Discord if you'd like to ask any questions, or just fancy hanging out!

Either way - thank you so much for the time and effort here ✨

@ellie ellie enabled auto-merge (squash) July 10, 2023 09:25
@ellie ellie merged commit 998bd5b into atuinsh:main Jul 10, 2023
8 checks passed
ealap pushed a commit to ealap/atuin that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants