Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: show cf tags in different color #17

Closed
ArtskydJ opened this issue Apr 8, 2015 · 12 comments
Closed

feature request: show cf tags in different color #17

ArtskydJ opened this issue Apr 8, 2015 · 12 comments

Comments

@ArtskydJ
Copy link

ArtskydJ commented Apr 8, 2015

Right now, <cf...> tags and normal html tags show up as the same color.

Maybe have a setting where coldfusion tags are highlighted some other color?

@ArtskydJ
Copy link
Author

Any chance of supporting this @atuttle?

@atuttle
Copy link
Owner

atuttle commented Apr 30, 2015

I think it's a great idea. Unfortunately i don't have the time or the motivation to learn the syntax for defining languages in atom (it's not my every day editor), so I can't add it. But pull requests are welcome. :)

@David-Polehonski
Copy link
Contributor

@ArtskydJ

Update: All cfml tags now have the class 'cfml' appened to them so you can define classes that target them in your own stylesheet now, see image below, it's not quite perfect yet but it's getting there.

tag-highlighting

@ArtskydJ
Copy link
Author

ArtskydJ commented Jul 7, 2015

@David-Polehonski Sweet, I hope to try this out as soon as #35 is merged and released. Thanks for your work on this!

@atuttle
Copy link
Owner

atuttle commented Jul 7, 2015

published. please close this issue once you've verified the fix. :)

@ArtskydJ
Copy link
Author

ArtskydJ commented Jul 7, 2015

Using version 0.8.4, adding the following to my styles.less file changes the cfml tags color:

atom-text-editor::shadow {
    .entity.name.tag.cfml {
        color: blue;
    }
}

Thanks!

@ArtskydJ ArtskydJ closed this as completed Jul 7, 2015
@ArtskydJ
Copy link
Author

ArtskydJ commented Jul 7, 2015

In case anyone's interested, this will highlight the < and > bits as well

atom-text-editor::shadow {
    .meta.tag.other.cfml, /* cffunction < and > */
    .punctuation.tag.cfml, /* other < and > */
    .entity.name.tag.cfml { /* tag names */
        color: #B80;
    }
}

@dajester2013
Copy link
Contributor

Just FYI for those who have a special place in their heart for cfeclipse, you may want to check out atom-theme-cfeclipse.

@kliakos
Copy link
Contributor

kliakos commented Jul 8, 2015

Any other ideas on cf tags color? Can't find anything really good.

@ArtskydJ
Copy link
Author

ArtskydJ commented Jul 8, 2015

@kliakos You mean the color of the tags? It depends on your theme, I suppose.

@atuttle
Copy link
Owner

atuttle commented Jul 8, 2015

Yep. I'm trying out apathy today, and using

atom-text-editor::shadow {
    .meta.tag.other.cfml, /* cffunction < and > */
    .punctuation.tag.cfml, /* other < and > */
    .entity.name.tag.cfml { /* tag names */
      color: #AC58FA;
    }
}

@ArtskydJ
Copy link
Author

ArtskydJ commented Jul 8, 2015

I'm using

atom-text-editor::shadow {
    .entity.name.tag.cfml {
        color: /* color here */;
    }
}

because otherwise the cffunction tags look funny.

And it more closely resembles how the html is highlighted in cfml files. (The html does not have < or > highlighted.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants