Ieškomų transporto priemonių duomenys #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirex
reviewed
Mar 18, 2022
| ,,,,,,,,,,,,,, | ||
| ,datasets/gov/pd/itpr,,,,,,,,,,,,, | ||
| ,,json2019,,,,json,,https://data.gov.lt/dataset/1668/download/10389/ITPR_2019%2001%2031.json,,,,,, | ||
| ,,json2020,,,,json,,https://data.gov.lt/dataset/1668/download/10390/ITPR_2020%2012%2031.json,,,,,, |
There was a problem hiding this comment.
Čia taip pat turėtu būti naudojamas parametrizavimas.
There was a problem hiding this comment.
sirex
reviewed
Mar 21, 2022
| ,,json2019,,,,json,,https://data.gov.lt/dataset/1668/download/10389/ITPR_2019%2001%2031.json,,,,,, | ||
| ,,json2020,,,,json,,https://data.gov.lt/dataset/1668/download/10390/ITPR_2020%2012%2031.json,,,,,, | ||
| ,,,,IeskomuTransportoPriemoniuRegistras,,,nationalid,,,,,,, | ||
| ,,,,,nationalid,integer,,nationalID,,3,open,,Nacionalinis ID, |
There was a problem hiding this comment.
Galvoju ar čia neturėtu būti susieta su Regitros duomenimis?
https://data.gov.lt/dataset/lietuvoje-iregistruotu-keliu-transporto-priemoniu-duomenys
| ,,json2020,,,,json,,https://data.gov.lt/dataset/1668/download/10390/ITPR_2020%2012%2031.json,,,,,, | ||
| ,,,,IeskomuTransportoPriemoniuRegistras,,,nationalid,,,,,,, | ||
| ,,,,,nationalid,integer,,nationalID,,3,open,,Nacionalinis ID, | ||
| ,,,,,nscode,string,,nsCode,,3,open,,Paieškos priežasties kodas, |
There was a problem hiding this comment.
Reikėtų pateikti enum, su galimų kodų sąrašu ir aprašymais.
| ,,,,,nationalid,integer,,nationalID,,3,open,,Nacionalinis ID, | ||
| ,,,,,nscode,string,,nsCode,,3,open,,Paieškos priežasties kodas, | ||
| ,,,,,nstitle,string,,nsTitle,,3,open,,Paieškos priežastis, | ||
| ,,,,,objekto_tipas,string,,objektoTipas,,3,open,,Objekto tipas, |
There was a problem hiding this comment.
Čia tikriausiai taip pat turėtu būti enum?
| ,,,,,nutraukimo_data,date,,nutraukimoData,,3,open,,Paieškos nutraukimo data, | ||
| ,,,,,paieskos_pradzia,date,,paieskosPradzia,,3,open,,Paieškos pradžios data, | ||
| ,,,,,paieskos_pabaiga,date,,paieskosPabaiga,,3,open,,Paiškos pabaigos data, | ||
| ,,,,,statusas,string,,statusas,,3,open,,Paieškos statusas, |
| ,,,,,valstybe,string,,valstybe,,3,open,,Valstybė, | ||
| ,,,,,nutraukimo_pagrindas,string,,nutraukimoPagrindas,,3,open,,Paieškos nutraukimo pagrindas, | ||
| ,,,,,nutraukimo_pagrindas_kt,string,,nutraukimoPagrindasKt,,3,open,,Paieškos butraukimo pagrindas (kita), | ||
| ,,,,,tipas,string,,tipas,,3,open,,Transporto priemonės tipas, |
There was a problem hiding this comment.
Manau, čia tikrai turėtu būti siejama su Regitros duomenimis, tik Regitros duomenys yra denormalizuoti, todėl nesusisies.
Gal būt reikėtų kelti Regitros duomenų brandos lygį?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.