Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate the fetching and loading of rates #15

Merged
merged 11 commits into from Sep 21, 2020
Merged

Separate the fetching and loading of rates #15

merged 11 commits into from Sep 21, 2020

Commits on Sep 18, 2020

  1. Extract method for fetching data

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    3583f8f View commit details
    Browse the repository at this point in the history

  2. Move data loading into bank class

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    9ff3bd2 View commit details
    Browse the repository at this point in the history

  3. Use better name for fetching rate data

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    c4ad019 View commit details
    Browse the repository at this point in the history

  4. Separate fetching and computing

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    dce9551 View commit details
    Browse the repository at this point in the history

  5. Reduce constants to lowest common denominator

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    d8660fa View commit details
    Browse the repository at this point in the history

  6. Reduce string interp to reduce noise

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    8a53373 View commit details
    Browse the repository at this point in the history

  7. Further simplify url computation

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    2e68308 View commit details
    Browse the repository at this point in the history

  8. Add test file for fetcher 

    This commit also relocates a test that is better kept with the fetcher.
Now the bank test is just an integration test that assures us everything
is wired up correctly.
    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    6d7f335 View commit details
    Browse the repository at this point in the history

  9. Use better names on integration test

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    2cae91d View commit details
    Browse the repository at this point in the history

  10. Promote shared setup

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    c5e6518 View commit details
    Browse the repository at this point in the history

  11. Update RuboCop todos

    @jonallured
    jonallured committed Sep 18, 2020
    Copy the full SHA
    3f272e9 View commit details
    Browse the repository at this point in the history