Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always shows newer version is available when curl is not installed. #93

Closed
DonkeeeyKong opened this issue Apr 4, 2024 · 2 comments
Closed

Always shows newer version is available when curl is not installed. #93

DonkeeeyKong opened this issue Apr 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@DonkeeeyKong
Copy link
Contributor

Thanks for the great script. I set it up yesterday (version 3.3). Everything worked well, the e-mail I got contained the following part though:

/opt/snapraid-aio-script/snapraid-aio-script.sh: Zeile 125: curl: Kommando nicht gefunden.
A newer version () is available! You can find more information by visiting https://github.com/auanasgheps/snapraid-aio-script/releases

Curl is not installed on my system. Looking into the code, the script seems to check if curl is installed only when Discord, Telegram or Healthcheck notifications are enabled. However, it is always used to check for updates as well, and, if not installed, produces the above output even when running the latest version of the script.
@auanasgheps
Copy link
Owner

Thanks for reporting! I will make the fix and hopefully do a quick hotfix release soon! (another bug was catched on #92)

@auanasgheps auanasgheps added the bug Something isn't working label Apr 8, 2024
auanasgheps added a commit that referenced this issue Apr 8, 2024
@auanasgheps
Install curl if check_updates is enabled
c18373d 
Check and install curl dependency if "CHECK_UPDATES" is enabled. #93
@auanasgheps
Copy link
Owner

I have fixed the issue in dev, pushing the update soon.

tehniemer added a commit to tehniemer/snapraid-aio-script that referenced this issue Apr 12, 2024
@tehniemer @auanasgheps
Merge dev updates into ignore testing (#39)
8546437 
* Update script-config.sh

No more dev tag

* Update snapraid-aio-script.sh

URL to be checked is in master branch
No more dev tags

* Improve documentation of SYNC_WARN_THRESHOLD

Fixes auanasgheps#89 
Better explain what SYNC_WARN_THRESHOLD does, including Forced Sync option. This explanation was pretty old, in fact was never updated since I started working on the script.

* Update README.md

Small tweaks

* Fix touch not running on SnapRAID 12.3

SnapRAID 12.3 has changed the string of the diff ouput, causing the script not to catch it.
Now it works in both cases.
auanasgheps#92

* Update snapraid-aio-script.sh

* Install curl if check_updates is enabled

Check and install curl dependency if "CHECK_UPDATES" is enabled. auanasgheps#93

* Update version

Update for 3.3.1

* Update script version

Update version to 3.3.1

* Add Star History

* Update index

---------

Co-authored-by: Oliver Cervera <cervera93-19@yahoo.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auanasgheps @DonkeeeyKong