Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another SEGV signal problem found #188

Closed
fCorleone opened this issue Jul 22, 2018 · 1 comment
Closed

Another SEGV signal problem found #188

fCorleone opened this issue Jul 22, 2018 · 1 comment
Labels

Comments

@fCorleone
Copy link

When I run the program aubionotes. The address sanitizer showed this:

=================================================================
==7800==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000004 (pc 0x7f0348775d3a bp 0x000000000007 sp 0x7fffc0b26750 T0)
    #0 0x7f0348775d39 in aubio_pitch_set_unit ../src/pitch/pitch.c:324
    #1 0x7f034876d079 in new_aubio_notes ../src/notes/notes.c:87
    #2 0x4051d4 in main ../examples/aubionotes.c:69
    #3 0x7f034838082f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #4 0x401508 in _start (/home/mfc_fuzz/aubio/build/dist/usr/local/bin/aubionotes+0x401508)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV ../src/pitch/pitch.c:324 aubio_pitch_set_unit
==7800==ABORTING

The input file of the program has been displayed at: https://github.com/fCorleone/fuzz_programs/blob/master/aubio/testcase3
The command line is just ./aubionotes testcase3

@piem
Copy link
Member

piem commented Aug 6, 2018

Hi again,

Two problems here, when processing a corrupt file with negative samplerates:

  • aubio_notes algorithm would keep trying even after pitch creation failed,
  • aubio_source_wavread would not give up when samplerate < 0

These two should be fixed in the branch fix/negative_samplerate.

thanks for reporting, piem

@piem piem added the security label Aug 6, 2018
@piem piem closed this as completed in 99c7aa2 Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants